Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webpack5: Only load babel config when babel-loader is used #25002

Merged
merged 2 commits into from
Nov 28, 2023

Conversation

valentinpalkovic
Copy link
Contributor

Closes N/A

What I did

Babel options should are only loaded when the babel-loader is in place

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@valentinpalkovic valentinpalkovic requested review from JReinhold and removed request for ndelangen November 28, 2023 08:19
@valentinpalkovic valentinpalkovic self-assigned this Nov 28, 2023
@valentinpalkovic valentinpalkovic changed the base branch from next to valentin/fix-react-docgen-for-nextjs November 28, 2023 08:21
@valentinpalkovic valentinpalkovic force-pushed the valentin/do-not-load-babel-options-in-swc-mode branch from 3d6f2aa to 02a271b Compare November 28, 2023 08:26
@valentinpalkovic valentinpalkovic force-pushed the valentin/do-not-load-babel-options-in-swc-mode branch from 02a271b to 0adaf29 Compare November 28, 2023 08:27
Base automatically changed from valentin/fix-react-docgen-for-nextjs to next November 28, 2023 09:04
@valentinpalkovic valentinpalkovic merged commit ca56066 into next Nov 28, 2023
60 checks passed
@valentinpalkovic valentinpalkovic deleted the valentin/do-not-load-babel-options-in-swc-mode branch November 28, 2023 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants